Skip to content

Orthogonal views #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Orthogonal views #42

wants to merge 17 commits into from

Conversation

AnniekStok
Copy link
Collaborator

Proposed Change

Add additional viewer models to view the orthogonal views (xz, yz) of the same data.
All interactive functionality (painting, selecting nodes, changing tool modes, undo/redo) should sync between the different viewers.

image

Checklist

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.

Further Comments

  • How to best extend/change this in order to also allow viewing different data (e.g. reference data) or the same data but at t+1? How can we best give the user more freedom about what to display in the different viewer models?
  • If the content of the different viewer models diverges from the main viewer, we will need separate Qt layer controls per layer per viewing model. Right now we only have the Qt layer controls of the layer on the main viewer, and sync the properties such as 'mode' and 'n_edit_dimensions'.
  • Currently the different viewer models are not dockable (though the window can optionally be hidden/resized). Trying to undock the entire widget kills the application for unclear reasons if it contains any viewer models :(

AnniekStok added 17 commits April 3, 2025 11:47
@AnniekStok
copy orthogonal views code from older version
341232f
@AnniekStok
Create QSplitter to optionally show the orthogonal views next to the …
2b61231 
…menu widget
@AnniekStok
separate crosswidget and multiple viewer widget
23ccd97
@AnniekStok
clean up orthogonal views widget
4de9b3c
@AnniekStok
wip adjusting the sizing of the orth views with respect to the menu w…
8fc2e98 
…idget
@AnniekStok
wip refactoring multipleviewer widget
e41207e
@AnniekStok
update the dims order of the orthogonal views based on its own rel_or…
ee70d45 
…der proeprty to be more flexible and allow different dimension orders in the future
@AnniekStok
set default axis labels
02e81ff
@AnniekStok
get rid of qtviewerwrap
e59a967
@AnniekStok
merge main
88fdac4
@AnniekStok
fix bug in naming axes
2ae1755
@AnniekStok
fix syncing issue on normal Labels layers
f8d36cf
@AnniekStok
remove unused trackviewer from multiple viewer widget
3df29e2
@AnniekStok
add tests for multiple viewer widget
2ac8429
@AnniekStok
bind shortcut to action_manager in the right place
98fe9e7
@AnniekStok
import center_cross_on_mouse function to register its action
4876b0c
@AnniekStok
skip testing the shortcut for center_cross_on_mouse since we only nee…
4794525 
…d to bind to it if the cross widget was imported
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 61.04746% with 238 lines in your changes missing coverage. Please review.

Project coverage is 89.17%. Comparing base (4614349) to head (4794525).

Files with missing lines Patch % Lines
...k_data_views/views/view_3d/multiple_view_widget.py 73.36% 57 Missing ⚠️
...inn/track_data_views/views/view_3d/cross_widget.py 31.42% 48 Missing ⚠️
finn/track_data_views/views/layers/track_labels.py 15.68% 43 Missing ⚠️
finn/track_data_views/views/layers/track_points.py 14.70% 29 Missing ⚠️
finn/track_application_menus/main_app.py 12.90% 27 Missing ⚠️
...nn/track_data_views/views/layers/contour_labels.py 35.13% 24 Missing ⚠️
...track_data_views/views/view_3d/orthogonal_views.py 40.00% 9 Missing ⚠️
finn/track_application_menus/menu_widget.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   89.41%   89.17%   -0.25%     
==========================================
  Files         650      655       +5     
  Lines       60090    60668     +578     
==========================================
+ Hits        53731    54099     +368     
- Misses       6359     6569     +210

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnniekStok @codecov-commenter